Migrating to const/let and Object Spread in more places#11535
Merged
gaearon merged 2 commits intofacebook:masterfrom Nov 19, 2017
Merged
Migrating to const/let and Object Spread in more places#11535gaearon merged 2 commits intofacebook:masterfrom
gaearon merged 2 commits intofacebook:masterfrom
Conversation
raphamorim
changed the title
raphamorim
changed the title
raphamorim
force-pushed
the
master
branch
2 times, most recently
from
fe1a6e7 to
669a157
Compare
clemmy
reviewed
Nov 13, 2017
| }; | ||
|
|
||
| var didWarn = {}; | ||
| let didWarn = {}; |
Contributor
There was a problem hiding this comment.
This can probably be a const, since it's never re-assigned.
clemmy
reviewed
Nov 13, 2017
| var ancestorInfo = Object.assign({}, oldInfo || emptyAncestorInfo); | ||
| var info = {tag: tag, instance: instance}; | ||
| const updatedAncestorInfo = function(oldInfo, tag, instance) { | ||
| let ancestorInfo = {...{}, ...(oldInfo || emptyAncestorInfo)}; |
clemmy
reviewed
Nov 13, 2017
|
|
||
| // https://html.spec.whatwg.org/multipage/syntax.html#special | ||
| var specialTags = [ | ||
| let specialTags = [ |
clemmy
reviewed
Nov 13, 2017
|
|
||
| var value = props.value; | ||
| var initialValue = value; | ||
| let initialValue = props.value; |
Contributor
There was a problem hiding this comment.
Hmm, wonder why it was written the other way initially. 😛
Contributor
Author
There was a problem hiding this comment.
te-hehe
Do you recommend putting it back?
I think it does not make sense to keep this line. Since it is the same reference.
Tradeoff: I guess it was written for better readability.
What do you think @clemmy
Contributor
There was a problem hiding this comment.
I think this is probably fine.
clemmy
reviewed
Nov 13, 2017
| }); | ||
| const hostProps = { | ||
| ...props, | ||
| ...{ |
Contributor
There was a problem hiding this comment.
How about:
const hostProps = {
...props,
value: undefined,
defaultValue: undefined,
children: '' + node._wrapperState.initialValue,
};
clemmy
reviewed
Nov 13, 2017
| var hostProps = Object.assign({children: undefined}, props); | ||
|
|
||
| var content = flattenChildren(props.children); | ||
| const hostProps = {...{children: undefined}, ...props}; |
Contributor
There was a problem hiding this comment.
Similar:
const hostProps = {children: undefined, ...props};
clemmy
suggested changes
Nov 13, 2017
Contributor
clemmy
left a comment
clemmy
left a comment
There was a problem hiding this comment.
Let me know if the comments I made make sense. :)
* Convert ReactDOMFiberTextarea to const/let * Convert ReactDOMSelection to const/let * Convert setTextContent to const/let * Convert validateDOMNesting to const/let
* Convert ReactDOMFiberOption to Object Spread * Convert ReactDOMFiberTextarea to Object Spread * Convert validateDOMNesting to Object Spread
Contributor
Author
|
Makes a lot of sense :D |
clemmy
approved these changes
Nov 13, 2017
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Use const/let in more places (facebook#11467) * Convert ReactDOMFiberTextarea to const/let * Convert ReactDOMSelection to const/let * Convert setTextContent to const/let * Convert validateDOMNesting to const/let * Replace Object.assign by Object Spread * Convert ReactDOMFiberOption to Object Spread * Convert ReactDOMFiberTextarea to Object Spread * Convert validateDOMNesting to Object Spread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.